fix: Warn instead of crashing when an empty dataset is being exported by janbuchar · Pull Request #342 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Conversation
Copy link
Collaborator
janbuchar
commented
Jul 22, 2024
janbuchar
commented
label
Jul 22, 2024
janbuchar
requested a review
from vdusek
github-actions
bot
assigned
janbuchar
github-actions
bot
added this to the
94th sprint - Tooling team milestone
vdusek approved these changes Jul 24, 2024
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe just changelog? depends on #330
Copy link
Collaborator Author
janbuchar
commented
Jul 24, 2024
janbuchar commented
Jul 24, 2024I think that's redundant at this point, #330 should be ready for testing now.
janbuchar
merged commit
22b95d1
into
master
janbuchar
deleted the
fix-crash-on-empty-dataset-export
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment