fix: pass crawler configuration to storages by janbuchar · Pull Request #375 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
Conversation
Copy link
Collaborator
janbuchar
commented
Jul 29, 2024
janbuchar
commented
This makes sure that storages opened via BasicCrawler.get_dataset and the like will use the same configuration object as the crawler. While this is relevant to #351, it does not fully resolve it (see #152).
labels
Jul 29, 2024
github-actions
bot
assigned
janbuchar
janbuchar
requested a review
from vdusek
github-actions
bot
added this to the
95th sprint - Tooling team milestone
github-actions
bot
added
the
tested
label
Jul 29, 2024vdusek approved these changes Jul 30, 2024
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
janbuchar
merged commit
b2d3a52
into
master
janbuchar
deleted the
pass-crawler-configuration-to-storages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment