Home Original page

feat(playwright): `infinite_scroll` helper by janbuchar · Pull Request #393 · apify/crawlee-python

@janbuchar

This implements a bare bones infinite scroll helper. It is also added into the crawling context.

@janbuchar

@janbuchar janbuchar added t-tooling

Issues with this label are in the ownership of the tooling team.

adhoc

Ad-hoc unplanned task added during the sprint.

labels

Aug 3, 2024

@barjin

Why not infinite_scroll?

(reading this on mobile, sorry if I'm missing something)

@B4nan

Yeah, I would stay consistent with the JS version.

@janbuchar

Sure thing, I'll change it

@janbuchar

@B4nan B4nan changed the title feat(playwright): scroll_to_bottom helper feat(playwright): infinite_scroll helper

Aug 5, 2024

vdusek

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just we could probably make module playwright_crawler/utils.py private, what do u think?

@janbuchar

LGTM, just we could probably make module playwright_crawler/utils.py private, what do u think?

Not sure. OG crawlee exposes this to the public, but it doesn't include it in the context.

@B4nan