Home Original page

fix: Remove redundant log, fix format by janbuchar · Pull Request #408 · apify/crawlee-python

@janbuchar

@janbuchar

@janbuchar janbuchar added t-tooling

Issues with this label are in the ownership of the tooling team.

adhoc

Ad-hoc unplanned task added during the sprint.

labels

Aug 7, 2024

B4nan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test case for this maybe? so its clear how it looks

@janbuchar

can we add a test case for this maybe? so its clear how it looks

We can, but should we? It sounds both flaky and fragile...

@B4nan

Well, I don't want any flaky tests, but you can mock everything out. My idea was a simple unit test where you log predefined stats and assert how they were logged.

@janbuchar

B4nan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats exactly what i meant 👍