fix: Correctly handle log level configuration by janbuchar · Pull Request #508 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Correctly handle log level configuration#508
fix: Correctly handle log level configuration#508
Conversation
Copy link
Collaborator
janbuchar
commented
Sep 9, 2024
janbuchar
commented
- The
CRAWLEE_VERBOSEandCRAWLEE_LOG_LEVELvariables are now respected by crawlee CrawleeLogFormatterdoesn't alter the record being formatted anymore- SDK counterpart coming soon
label
Sep 9, 2024
janbuchar
requested a review
from vdusek
github-actions
bot
assigned
janbuchar
github-actions
bot
added this to the
98th sprint - Tooling team milestone
vdusek requested changes Sep 10, 2024
src/crawlee/configuration.py
Outdated
Show resolved
Hide resolved
src/crawlee/configuration.py Outdated Show resolved Hide resolved
src/crawlee/basic_crawler/_basic_crawler.py
Show resolved
Hide resolved
src/crawlee/basic_crawler/_basic_crawler.py Show resolved Hide resolved
src/crawlee/_log_config.py
Show resolved
Hide resolved
src/crawlee/_log_config.py Show resolved Hide resolved
vdusek approved these changes Sep 10, 2024
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the CRITICAL thing, otherwise LGTM 🚀
janbuchar added 2 commits
September 10, 2024 11:21
janbuchar
merged commit
7ea8fe6
into
master
janbuchar
deleted the
logging-config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment