fix: use explicitly UTF-8 encoding in local storage by vdusek · Pull Request #533 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Conversation
Copy link
Collaborator
vdusek
commented
Sep 18, 2024
vdusek
commented
- All occurrences should be updated.
- Closes: Example code beautifulsoup_crawler.py not working on Windows due to encoding assumptions. #532
vdusek
requested a review
from janbuchar
github-actions
bot
assigned
vdusek
github-actions
bot
added this to the
98th sprint - Tooling team milestone
github-actions
bot
added
the
t-tooling
label
Sep 18, 2024github-actions bot reviewed Sep 18, 2024
Copy link
Contributor
github-actions
bot
left a comment
github-actions
bot
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Pull Request Tookit has failed!
Pull request is neither linked to an issue or epic nor labeled as adhoc!
janbuchar approved these changes Sep 19, 2024
Copy link
Collaborator
janbuchar
left a comment
janbuchar
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vdusek
merged commit
a3a0ab2
into
master
vdusek
deleted the
push-data-uses-explicitly-utf-8
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment