feat!: Add headers in unique key computation by Prathamesh010 · Pull Request #609 · apify/crawlee-python
Please run the ci @vdusek. Thank you
vdusek
left a comment
•
Loading
vdusek
left a comment
•
Loading
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use HttpHeaders type for headers? It should also help with the normalization. Otherwise, it looks solid.
The Requested changes are done. @vdusek Please have a look
vdusek
changed the title
feat: Add headers in unique key computation
feat!: Add headers in unique key computation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Prathamesh010, I made a few more changes there, otherwise it looks great. Thank you for your contribution.
why was this marked as breaking change?
why was this marked as breaking change?
The interface remained the same, but the computation of the extended unique key was changed. It will be released in 0.4 together with #542.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters