fix: Fix total_size usage in memory size monitoring by janbuchar · Pull Request #661 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Fix total_size usage in memory size monitoring#661
fix: Fix total_size usage in memory size monitoring#661
Conversation
Copy link
Collaborator
SDK passes max memory usage as total_size, and we don't actually use that field anyway, so let's just drop it
labels
Nov 6, 2024
janbuchar
requested review from
Pijukatel and
vdusek
github-actions
bot
assigned
janbuchar
github-actions
bot
added this to the
102nd sprint - Tooling team milestone
github-actions
bot
added
the
tested
label
Nov 6, 2024janbuchar added 2 commits
November 6, 2024 17:15vdusek approved these changes Nov 7, 2024
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really do not need it, then LGTM.
janbuchar
merged commit
c2a3239
into
master
janbuchar
deleted the
clarify-total-memory-size
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment