fix: Fix unhandled ValueError in request handler result processing by janbuchar · Pull Request #666 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: Fix unhandled ValueError in request handler result processing#666
fix: Fix unhandled ValueError in request handler result processing#666
Conversation
Copy link
Collaborator
janbuchar
commented
Nov 7, 2024
janbuchar
commented
We only checked the limit when committing the result, when the request handler was already considered successful. I added a check that results in an error before the request proceeds.
labels
Nov 7, 2024
janbuchar
requested review from
Pijukatel and
vdusek
github-actions
bot
assigned
janbuchar
github-actions
bot
added this to the
102nd sprint - Tooling team milestone
github-actions
bot
added
the
tested
label
Nov 7, 2024Pijukatel reviewed Nov 10, 2024
tests/unit/basic_crawler/test_basic_crawler.py
Show resolved
Hide resolved
tests/unit/basic_crawler/test_basic_crawler.py Show resolved Hide resolved
Pijukatel reviewed Nov 10, 2024
src/crawlee/_types.py
Show resolved
Hide resolved
src/crawlee/_types.py Show resolved Hide resolved
vdusek approved these changes Nov 11, 2024
Copy link
Collaborator
vdusek
left a comment
•
edited
Loading
vdusek
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jus the discussion. Otherwise LGTM.
tests/unit/basic_crawler/test_basic_crawler.py
Show resolved
Hide resolved
tests/unit/basic_crawler/test_basic_crawler.py Show resolved Hide resolved
Pijukatel approved these changes Nov 11, 2024
janbuchar
merged commit
0a99d7f
into
master
janbuchar
deleted the
fix-unhandled-value-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment