fix: Make result of RequestList.is_empty independent of fetch_next_request calls by janbuchar · Pull Request #876

fix: Make result of RequestList.is_empty independent of fetch_next_request calls by janbuchar · Pull Request #876 · apify/crawlee-python

Conversation

The old version of RequestList only updated the _is_empty flag on fetch_next_request calls, which was not enough. This PR updates it so that the is_empty method also tries to dequeue a request from the iterator before returning a result.

janbuchar added t-tooling

Issues with this label are in the ownership of the tooling team.

adhoc

Ad-hoc unplanned task added during the sprint.

labels

Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test case that covers the issue from the SDK?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels