fix: restore proxy functionality for PlaywrightCrawler broken in v0.5 by Mantisus · Pull Request #889 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
fix: restore proxy functionality for PlaywrightCrawler broken in v0.5#889
vdusek merged 3 commits intoapify:masterfrom
fix: restore proxy functionality for PlaywrightCrawler broken in v0.5#889
vdusek merged 3 commits intoapify:masterfrom
Conversation
Copy link
Collaborator
Mantisus
commented
Jan 9, 2025
Mantisus
commented
Description
- fix for proxy in PlaywrightCrawler
Issues
Testing
- Added test to verify proxy is correctly set for PlaywrightCrawler
Mantisus added 2 commits
January 9, 2025 04:10
Mantisus
self-assigned this
B4nan
changed the title
fix: restore proxy functionality for PlaywrightCrawler broken in 5.0
fix: restore proxy functionality for PlaywrightCrawler broken in v0.5
janbuchar
requested review from
Pijukatel and
vdusek
and removed request for
Pijukatel
vdusek reviewed Jan 9, 2025
tests/unit/crawlers/_playwright/test_playwright_crawler.py
Show resolved
Hide resolved
tests/unit/crawlers/_playwright/test_playwright_crawler.py Show resolved Hide resolved
Mantisus
requested a review
from vdusek
Pijukatel approved these changes Jan 10, 2025
vdusek approved these changes Jan 15, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vdusek
merged commit
908c944
into
apify:master
vdusek
added this to the
106th sprint - Tooling team milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants