fix: fix `BrowserPool` and `PlaywrightBrowserPlugin` closure by Mantisus · Pull Request #932 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
vdusek merged 1 commit intoapify:masterfrom
Jan 29, 2025Merged
fix: fix BrowserPool and PlaywrightBrowserPlugin closure#932
vdusek merged 1 commit intoapify:masterfrom
fix: fix BrowserPool and PlaywrightBrowserPlugin closure#932
vdusek merged 1 commit intoapify:masterfrom
Conversation
Copy link
Collaborator
Mantisus
commented
Jan 24, 2025
Mantisus
commented
Description
- Fix the
BrowserPoolandPlaywrightBrowserPluginclosures. Without it, the application crashes whenPlaywrightCrawleris run in sequence again.
Copy link
Collaborator Author
self._playwright_context_manager = async_playwright()
in PlaywrightBrowserPlugin.__aexit__ is needed because Playwright sets a flag that the manager has been closed - https://github.com/microsoft/playwright-python/blob/main/playwright/async_api/_context_manager.py#L56
janbuchar
requested review from
Pijukatel and
vdusek
Pijukatel approved these changes Jan 27, 2025
vdusek approved these changes Jan 29, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Mantisus
labels
Jan 29, 2025
vdusek
added this to the
107th sprint - Tooling team milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment