fix: fix `CurlImpersonateHttpClient` cookies handler by Mantisus · Pull Request #946 · apify/crawlee-python
Could you add a test please?
Could you add a test please?
Yeah sure, but I need that PR #947 for these tests 🙂
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM.
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some test-related nits, other than that, it looks good
Co-authored-by: Jan Buchar <Teyras@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters