fix: fix session managment with retire by Mantisus · Pull Request #947 · apify/crawlee-python
Navigation Menu
{{ message }}
apify / crawlee-python Public
- Notifications You must be signed in to change notification settings
- Fork 705
Merged
vdusek merged 1 commit intoapify:masterfrom
Jan 31, 2025Merged
fix: fix session managment with retire#947
vdusek merged 1 commit intoapify:masterfrom
fix: fix session managment with retire#947
vdusek merged 1 commit intoapify:masterfrom
Conversation
Copy link
Collaborator
Mantisus
commented
Jan 30, 2025
Mantisus
commented
Description
- Fix cases where a session was not excluded from the pool after calling
session.retire()inside a successfulrequest_handler.
Mantisus
mentioned this pull request
Mantisus
requested a review
from janbuchar
Mantisus
self-assigned this
janbuchar approved these changes Jan 31, 2025
vdusek approved these changes Jan 31, 2025
Copy link
Collaborator
vdusek
left a comment
vdusek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants