fix: fix convert relative link to absolute in `enqueue_links` for response with redirect by Mantisus · Pull Request #956

fix: fix convert relative link to absolute in `enqueue_links` for response with redirect by Mantisus · Pull Request #956 · apify/crawlee-python

Mantisus changed the title ~~fix: fix enqueue_links for response with redirect~~ fix: fix convert relative link to absolute in enqueue_links for response with redirect

Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea for a test? Couldn't we utilize httpbin? ... if there is no easy way, it is not necessary I would say. Otherwise LGTM 🙂.

Any idea for a test? Couldn't we utilize httpbin? ... if there is no easy way, it is not necessary I would say. Otherwise LGTM 🙂.

I agree it would be nice to have a test for it to properly describe the scenario in which this is a problem. Maybe something from https://httpbin.org/#/Redirects can be used to create such scenario?

Updated the current test for enqueue_links to work as expected behavior when a redirect exists