Write W3C capabilities into firstMatch entity instead of alwaysMatch by mykola-mokhnach · Pull Request #1010

Write W3C capabilities into firstMatch entity instead of alwaysMatch by mykola-mokhnach · Pull Request #1010 · appium/java-client

Merged

mykola-mokhnach merged 1 commit intoappium:masterfrom

mykola-mokhnach:first_match

Aug 28, 2018

Merged

Write W3C capabilities into firstMatch entity instead of alwaysMatch#1010
mykola-mokhnach merged 1 commit intoappium:masterfrom
mykola-mokhnach:first_match

Conversation

Copy link Copy Markdown

Contributor

mykola-mokhnach commented
Aug 28, 2018

Change list

Just did the same what Selenium is already doing: https://github.com/SeleniumHQ/selenium/blob/479a801b39efa53966e35eec0bae55ca0bcc02da/java/client/src/org/openqa/selenium/remote/NewSessionPayload.java#L252

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Write W3C capabilities into firstMatch entity instead of alwaysMatch

9835fcc

mykola-mokhnach requested review from KazuCocoa, SrinivasanTarget and TikhomirovSergey

August 28, 2018 05:32

KazuCocoa approved these changes Aug 28, 2018

View reviewed changes

Copy link Copy Markdown

Member

KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks 👍
I'll work for Ruby and Python. appium/ruby_lib_core#137
(Python has the same issue in selenium, I guess... Anyway, I'll take a look)