Add threshold argument to OccurrenceMatchingOptions by mykola-mokhnach · Pull Request #1060 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
saikrishna321 merged 2 commits intoappium:masterfrom
Nov 19, 2018Merged
Add threshold argument to OccurrenceMatchingOptions#1060
saikrishna321 merged 2 commits intoappium:masterfrom
Add threshold argument to OccurrenceMatchingOptions#1060
saikrishna321 merged 2 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Nov 19, 2018
mykola-mokhnach
commented
Change list
Add the previously forgotten argument
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
Addresses appium/appium#11705
mykola-mokhnach
requested a review
from SrinivasanTarget
SrinivasanTarget approved these changes Nov 19, 2018
Copy link Copy Markdown
Member
SrinivasanTarget
left a comment
SrinivasanTarget
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Copy link Copy Markdown
Member
saikrishna321
commented
Nov 19, 2018
saikrishna321 commented
Nov 19, 2018@mykola-mokhnach can you please fix Travis style check https://travis-ci.org/appium/java-client/jobs/457112933#L3667
saikrishna321 approved these changes Nov 19, 2018
saikrishna321
merged commit
f20a2f7
into
appium:master
mykola-mokhnach
mentioned this pull request
mykola-mokhnach
deleted the
add_threshold
branch
mykola-mokhnach
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment