Delete deprecated methods by SrinivasanTarget · Pull Request #1077 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
SrinivasanTarget merged 3 commits intoappium:masterfrom
Dec 28, 2018Merged
Delete deprecated methods#1077
SrinivasanTarget merged 3 commits intoappium:masterfrom
Delete deprecated methods#1077
SrinivasanTarget merged 3 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Member
SrinivasanTarget
commented
Dec 28, 2018
SrinivasanTarget
commented
Change list
Delete deprecated methods
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
SrinivasanTarget
requested a review
from mykola-mokhnach
| @@ -166,27 +166,17 @@ protected By buildMobileNativeBy() { | |||
| Optional<HowToUseLocators> howToUseLocatorsOptional = ofNullable(howToUseLocators); | |||
|
|
|||
| By result = null; | |||
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this variable still used?
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it's not used, have deleted it now.
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Dec 28, 2018
mykola-mokhnach commented
Dec 28, 2018It also makes sense to check the failing job on Azure CI: https://dev.azure.com/srinivasansekar/java-client/_build/results?buildId=74
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Dec 28, 2018
mykola-mokhnach commented
Dec 28, 2018Checkstyle is still not very happy
appium
deleted a comment
mykola-mokhnach approved these changes Dec 28, 2018
SrinivasanTarget
merged commit
67112e6
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants