Add the missing Android and iOS settings by mykola-mokhnach · Pull Request #1120 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
saikrishna321 merged 3 commits intoappium:masterfrom
Mar 12, 2019Merged
Add the missing Android and iOS settings#1120
saikrishna321 merged 3 commits intoappium:masterfrom
Add the missing Android and iOS settings#1120
saikrishna321 merged 3 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Mar 11, 2019
mykola-mokhnach
commented
Change list
Addresses #1119
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
mykola-mokhnach added 2 commits
March 11, 2019 20:54
mykola-mokhnach
requested review from
SrinivasanTarget and
jlipps
saikrishna321 approved these changes Mar 11, 2019
Copy link Copy Markdown
Member
saikrishna321
commented
Mar 11, 2019
saikrishna321 commented
Mar 11, 2019@mykola-mokhnach can you pls get travis happy
/home/travis/build/appium/java-client/src/main/java/io/appium/java_client/android/HasAndroidSettings.java:119: error: bad HTML entity
* Whether to return compact (standards-compliant) & faster responses in find element/s
SrinivasanTarget approved these changes Mar 12, 2019
saikrishna321
merged commit
9d33a4e
into
appium:master
mykola-mokhnach
deleted the
settings
branch
ogasawara-shift
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment