Add the missing settings which introduced in appium 1.12 and 1.13 by takeyaqa · Pull Request #1156 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom
takeyaqa:add_missing_settings
Jun 14, 2019Merged
Add the missing settings which introduced in appium 1.12 and 1.13#1156
mykola-mokhnach merged 1 commit intoappium:masterfrom
takeyaqa:add_missing_settings
Add the missing settings which introduced in appium 1.12 and 1.13#1156
mykola-mokhnach merged 1 commit intoappium:masterfrom
takeyaqa:add_missing_settings
Conversation
Copy link Copy Markdown
takeyaqa
commented
Jun 14, 2019
takeyaqa
commented
Change list
- add the missing settings which introduced in appium 1.12 and 1.13
- shutdownOnPowerDisconnect
- mjpegScalingFactor
- autoUpdateImageElementPosition
- fixImageTemplateScale
- defaultImageTemplateScale
- fix javadocs
- use https
- fix wrong default values
- add tests
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
* add the missing setting which introduced in appium 1.12 and 1.13 * fix javadoc * add test
mykola-mokhnach approved these changes Jun 14, 2019
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Jun 14, 2019
mykola-mokhnach commented
Jun 14, 2019thanks
mykola-mokhnach
merged commit
1aac740
into
appium:master
takeyaqa
deleted the
add_missing_settings
branch
ogasawara-shift
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants