Avoid enforcing the platform name while creating drivers by mykola-mokhnach · Pull Request #1164

Avoid enforcing the platform name while creating drivers by mykola-mokhnach · Pull Request #1164 · appium/java-client

Conversation

Change list

Addresses #1162

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I hope the change won't affect much clients, but the current logic there is anyway incorrect and must be fixed.

mykola-mokhnach changed the title ~~Avoid enforcing the platform name while creating drivers~~ [WIP] Avoid enforcing the platform name while creating drivers

Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

		*/
		protected static Capabilities setDefaultPlatformName(Capabilities originalCapabilities,
		String newPlatform) {
		if (originalCapabilities.getCapability(PLATFORM_NAME) == null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mykola-mokhnach changed the title ~~[WIP] Avoid enforcing the platform name while creating drivers~~ Avoid enforcing the platform name while creating drivers

Jun 25, 2019