fix: Avoid throwing null pointer exception if any of settings is equal to null by mykola-mokhnach · Pull Request #1241 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom
Sep 24, 2019Merged
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Sep 23, 2019
mykola-mokhnach
commented
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
Recently Appium started retuning null as setting value. This breaks ImmutableMap implementation, which does not allow nulls as values.
Addresses https://dev.azure.com/srinivasansekar/java-client/_build/results?buildId=290&view=ms.vss-test-web.build-test-results-tab&runId=1000428&resultId=100049&paneView=debug
mykola-mokhnach
requested a review
from SrinivasanTarget
KazuCocoa approved these changes Sep 24, 2019
mykola-mokhnach
merged commit
53814cd
into
appium:master
mykola-mokhnach
deleted the
null_map
branch
mykola-mokhnach
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants