Home Original page

feat: add support for logCustomEvent command by jlipps · Pull Request #1262 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jlipps

Copy link Copy Markdown

Member

@jlipps jlipps commented

Nov 4, 2019

Depends on appium/appium-base-driver#364

(I couldn't get tests to run due to some Class Not Found error that seems unrelated.)

@jlipps

Copy link Copy Markdown

Member Author

jlipps commented

Nov 6, 2019

The Azure failure is a timeout of some kind and it seems to have existed since before this PR; not sure what to do about that.

@jlipps jlipps force-pushed the jlipps-custom-log branch from 8052484 to 760df68 Compare

November 6, 2019 17:34

@jlipps jlipps force-pushed the jlipps-custom-log branch from 760df68 to 5c22d6c Compare

November 6, 2019 17:52

public final List<CommandEvent> commands;
public final List<TimedEvent> events;
public final String jsonData;
Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be string or JSONObject?

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string, because its only purpose is to write out to disk.

@SrinivasanTarget SrinivasanTarget merged commit fcf8581 into master

Nov 6, 2019

@SrinivasanTarget SrinivasanTarget deleted the jlipps-custom-log branch

November 6, 2019 19:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlipps @mykola-mokhnach @SrinivasanTarget