feat: Add idempotency key to session creation requests by mykola-mokhnach · Pull Request #1327 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom
Apr 1, 2020Merged
feat: Add idempotency key to session creation requests#1327
mykola-mokhnach merged 2 commits intoappium:masterfrom
feat: Add idempotency key to session creation requests#1327
mykola-mokhnach merged 2 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Mar 31, 2020
mykola-mokhnach
commented
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
This PR adds a random idempotency key to each session creation request. This is necessary to properly handle HTTP request retries. Read appium/appium-base-driver#400 for more details.
mykola-mokhnach
requested review from
KazuCocoa and
SrinivasanTarget
KazuCocoa approved these changes Mar 31, 2020
SrinivasanTarget approved these changes Mar 31, 2020
Copy link Copy Markdown
Member
SrinivasanTarget
commented
Mar 31, 2020
SrinivasanTarget commented
Mar 31, 2020CI is not happy yet since server-side changes aren't available in beta.
mykola-mokhnach
changed the title
feat: Add idempotency key to session creation requests
[WIP] feat: Add idempotency key to session creation requests
Copy link Copy Markdown
Contributor Author
@SrinivasanTarget No, unfortunately this is a bug on the server side that is most likely related to keepAlive option and socket reuse. I'll take care about it and restart the test after the patch is merged
mykola-mokhnach
changed the title
[WIP] feat: Add idempotency key to session creation requests
feat: Add idempotency key to session creation requests
mykola-mokhnach
merged commit
5d6cf9d
into
appium:master
mykola-mokhnach
deleted the
idemp
branch
Copy link Copy Markdown
Contributor Author
mykola-mokhnach
commented
Apr 1, 2020
mykola-mokhnach commented
Apr 1, 2020All works with the recent base driver patch.
cc @KazuCocoa
KazuCocoa
mentioned this pull request
This was referenced
Apr 2, 2020
mykola-mokhnach
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants