fix: Increase the timeout for graceful service termination by mykola-mokhnach · Pull Request #1354 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom
May 27, 2020Merged
fix: Increase the timeout for graceful service termination#1354
mykola-mokhnach merged 2 commits intoappium:masterfrom
fix: Increase the timeout for graceful service termination#1354
mykola-mokhnach merged 2 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
May 27, 2020
mykola-mokhnach
commented
Change list
Selenium lib hardcodes the graceful shutdown timeout to 2 seconds (zero on Windows). This is not enough for Appium to properly shutdown all the drivers and clean up the leftovers.
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
mykola-mokhnach
requested review from
KazuCocoa and
SrinivasanTarget
SrinivasanTarget approved these changes May 27, 2020
|
|
||
| // This all magic is necessary, because Selenium does not publicly expose | ||
| // process killing timeouts. By default a process is killed forcibly if | ||
| // it does not exit after two seconds, which is in most cases not enough for |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a process is killed forcibly if it does not exist after two seconds
Interesting.
mykola-mokhnach
merged commit
d1d0f78
into
appium:master
mykola-mokhnach
deleted the
service_kill
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants