fix: Update Service to properly work with options by mykola-mokhnach · Pull Request #1550 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 8 commits intoappium:masterfrom
Oct 26, 2021Merged
fix: Update Service to properly work with options#1550
mykola-mokhnach merged 8 commits intoappium:masterfrom
fix: Update Service to properly work with options#1550
mykola-mokhnach merged 8 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Oct 26, 2021
mykola-mokhnach
commented
Change list
This fix ensures that AppiumLocalService handles driver options properly
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
mykola-mokhnach added 8 commits
October 25, 2021 19:13… into service_fixes # Conflicts: # src/test/java/io/appium/java_client/service/local/StartingAppLocallyTest.java
mykola-mokhnach
requested a review
from valfirst
SrinivasanTarget approved these changes Oct 26, 2021
mykola-mokhnach
merged commit
4d944ae
into
appium:master
mykola-mokhnach
deleted the
service_fixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants