fix: #1660 - correction for ping method to get proper status URL in case of a basepath provided by robinGupta11392 · Pull Request #1661

fix: #1660 - correction for ping method to get proper status URL in case of a basepath provided by robinGupta11392 · Pull Request #1661 · appium/java-client

and others added 3 commits

March 17, 2022 16:04

…ervice is not able to start - checkStatus is failing

Fix for basePath appending logic to fix Issue appium#1660

robinGupta11392 changed the title ~~Fix for Issue #1660 - correction for ping method to get proper status URL in case of a basepath provided~~ Fix: #1660 - correction for ping method to get proper status URL in case of a basepath provided

Mar 17, 2022

…LocalService.java


Removing redundant parenthesis

Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>

mykola-mokhnach changed the title ~~Fix: #1660 - correction for ping method to get proper status URL in case of a basepath provided~~ fix: #1660 - correction for ping method to get proper status URL in case of a basepath provided

Mar 18, 2022

…reviews

- replaced String#isBlank with StringUtils#isBlank for Java language compatibility
- introduced InvalidBasePathException to be thrown for blank/null/empty values of basepath
- basePath validations moved to the step of storing server arguments to give forward compatibility with Appium v2
fix: added extra test cases for more precisely testing basepath validations

removed redundant validation of StringUtils#isBlank() on the basepath
replaced Assert#fail with Assert#assertThrows for the test cases

…eBuilder.java

Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>

Removed validations of exception message in the tests
Accepted the change from val to use checkArgument method from Preconditions class