test: fix open notification test by anujkumar21 · Pull Request #1749 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom
Aug 26, 2022Merged
test: fix open notification test#1749
mykola-mokhnach merged 1 commit intoappium:masterfrom
test: fix open notification test#1749
mykola-mokhnach merged 1 commit intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
anujkumar21
commented
Aug 26, 2022
anujkumar21
commented
Change list
Test openNotification was failing because on the current version 'settings_button' is not visible, so added check for different element. Also add the test to CI.
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Copy link Copy Markdown
The committers listed above are authorized under a signed CLA.
- ✅ login: anujkumar21 / name: Anuj Kumar (0f5f4e1)
valfirst approved these changes Aug 26, 2022
valfirst
requested review from
SrinivasanTarget and
mykola-mokhnach
mykola-mokhnach approved these changes Aug 26, 2022
mykola-mokhnach
merged commit
80be558
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants