fix: Properly unwrap driver instance if the ContextAware object is deeply nested by mykola-mokhnach · Pull Request #2052 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 5 commits intoappium:masterfrom
Oct 22, 2023Merged
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Oct 19, 2023
mykola-mokhnach
commented
Change list
Related to #2051
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
mykola-mokhnach added 3 commits
October 20, 2023 01:06
mykola-mokhnach
changed the title
fix: Properly unwrap driver instance if the ContextAware object is deeply nested
WIP: fix: Properly unwrap driver instance if the ContextAware object is deeply nested
mykola-mokhnach
changed the title
WIP: fix: Properly unwrap driver instance if the ContextAware object is deeply nested
fix: Properly unwrap driver instance if the ContextAware object is deeply nested
Copy link Copy Markdown
Contributor Author
mykola-mokhnach
commented
Oct 21, 2023
mykola-mokhnach commented
Oct 21, 2023Failed android tests are expected because the CI fails to start emulator. The fix itself works properly though
SrinivasanTarget approved these changes Oct 22, 2023
mykola-mokhnach
merged commit
fac489f
into
appium:master
mykola-mokhnach
deleted the
wraps_check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants