refactor: Deprecate custom functional interfaces by valfirst · Pull Request #2055 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
valfirst merged 1 commit intoappium:masterfrom
Oct 26, 2023Merged
refactor: Deprecate custom functional interfaces#2055
valfirst merged 1 commit intoappium:masterfrom
refactor: Deprecate custom functional interfaces#2055
valfirst merged 1 commit intoappium:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
valfirst
commented
Oct 24, 2023
valfirst
commented
Change list
Custom functional interfaces are not needed anymore: Selenium closed all gaps in functional Java support.
Types of changes
What types of changes are you proposing/introducing to Java client?
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
valfirst
requested review from
SrinivasanTarget,
mykola-mokhnach and
saikrishna321
as code owners
| @@ -27,16 +27,13 @@ | |||
|
|
|||
| public class AndroidFunctionTest extends BaseAndroidTest { | |||
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test does not make sense if it uses standard functions. It must be removed together with the deprecated stuff
valfirst
force-pushed
the
deprecate-custom-functional-interfaces
branch
from
d83e403 to
8a14133
Compare
valfirst
requested a review
from mykola-mokhnach
|
|
||
| public class AndroidAbilityToUseSupplierTest extends BaseAndroidTest { | ||
|
|
||
| private final ActionSupplier<AndroidTouchAction> horizontalSwipe = () -> { |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to tests. We will remove it as soon as deprecated interfaces are removed
valfirst
force-pushed
the
deprecate-custom-functional-interfaces
branch
from
8a14133 to
dba99a8
Compare
valfirst
requested a review
from mykola-mokhnach
mykola-mokhnach approved these changes Oct 26, 2023
valfirst
merged commit
a6ebbeb
into
appium:master
valfirst
deleted the
deprecate-custom-functional-interfaces
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants