chore: Introduce better constructor argument validation for the AppiumFieldDecorator class by mykola-mokhnach · Pull Request #2070 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom
Nov 6, 2023Merged
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Nov 6, 2023
mykola-mokhnach
commented
Change list
I see cases where users unexpectedly pass null values to AppiumFieldDecorator constructor and then get confused. this change should help to better diagnose such situation
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
…mFieldDecorator class
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
valfirst approved these changes Nov 6, 2023
mykola-mokhnach
merged commit
5298e9c
into
appium:master
mykola-mokhnach
deleted the
null_check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants