Home Original page

chore: Add non-W3C Location-management endpoints deprecated in Selenium client by valfirst · Pull Request #2098 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@valfirst

Copy link Copy Markdown

Collaborator

Change list

Add non-W3C Location-management endpoints deprecated in Selenium client: https://github.com/SeleniumHQ/selenium/pull/13372/files#diff-1af793ae2090a0cb691f1efbb3ee0d2b186c4027c5b441f6f3d55b3663e67ba1

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst valfirst force-pushed the add-non-w3c-location-management-endpoints-deprecated-in-selenium-client branch from 06feb1f to 5f36e28 Compare

January 14, 2024 17:45
locationParameters.put("latitude", location.getLatitude());
locationParameters.put("longitude", location.getLongitude());
Optional.ofNullable(location.getAltitude()).ifPresent(altitude -> locationParameters.put("altitude", altitude));
execute(MobileCommand.SET_LOCATION, Map.of("location", location));
Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locationParameters ?

@valfirst valfirst merged commit 6ac3d9b into appium:master

Jan 15, 2024

@valfirst valfirst deleted the add-non-w3c-location-management-endpoints-deprecated-in-selenium-client branch

January 15, 2024 19:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@saikrishna321 saikrishna321 Awaiting requested review from saikrishna321 saikrishna321 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valfirst @mykola-mokhnach @SrinivasanTarget