fix: Fix Selenium 4.34.0+ compatibility by valfirst · Pull Request #2298 · appium/java-client
Change list
ContextAwareinterface was removed from Selenium: SeleniumHQ/selenium@3c25c92.io.appium.java_client.remote.SupportsContextSwitchingwill be a replacement for the removed interface.
Closes #2296.
Types of changes
What types of changes are you proposing/introducing to Java client?
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
Note: new release will be required once new Selenium release is published.
|
|
||
| public class EmptyWebDriver implements WebDriver, ContextAware, | ||
| JavascriptExecutor, HasCapabilities, TakesScreenshot { | ||
| public class EmptyWebDriver implements WebDriver, JavascriptExecutor, HasCapabilities, TakesScreenshot { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it instead implement SupportsContextSwitching ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the corresponding methods, they were not used
valfirst
deleted the
fix-selenium-4-34-0-compatibility
branch
@valfirst Selenium 4.34.0 has been released, are you going to release Appium as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters