feat: add support for descendant and ancestor flutter locators by sudharsan-selvaraj · Pull Request #2357 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
SrinivasanTarget merged 7 commits intoappium:masterfrom
Oct 9, 2025Merged
feat: add support for descendant and ancestor flutter locators#2357
SrinivasanTarget merged 7 commits intoappium:masterfrom
feat: add support for descendant and ancestor flutter locators#2357
SrinivasanTarget merged 7 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
sudharsan-selvaraj
commented
Oct 9, 2025
sudharsan-selvaraj
commented
Change list
Added new locator strategies AppiumBy.flutterDescendant and AppiumBy.flutterAncestor to support flutter's descendant and ancestor finders.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
sudharsan-selvaraj added 2 commits
October 9, 2025 10:27
sudharsan-selvaraj
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
saikrishna321 requested changes Oct 9, 2025
src/main/java/io/appium/java_client/AppiumBy.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java Outdated Show resolved Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java Outdated Show resolved Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java Outdated Show resolved Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java Outdated Show resolved Hide resolved
Copy link Copy Markdown
Member
saikrishna321
commented
Oct 9, 2025
saikrishna321 commented
Oct 9, 2025@sudharsan-selvaraj Please fix the CI for checkstyle
Copy link Copy Markdown
Contributor Author
I'm currently looking into the test failure for ios and will address it.
sudharsan-selvaraj
requested a review
from saikrishna321
valfirst reviewed Oct 9, 2025
src/main/java/io/appium/java_client/AppiumBy.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/AppiumBy.java Outdated Show resolved Hide resolved
sudharsan-selvaraj added 3 commits
October 9, 2025 16:09| } | ||
|
|
||
| static String formatLocator(FlutterBy of, FlutterBy matching, Map<String, Object> properties) { | ||
| Map<String, Object> locator = new HashMap<>(); |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also use Map.of like above?
mykola-mokhnach approved these changes Oct 9, 2025
sudharsan-selvaraj
requested a review
from valfirst
valfirst approved these changes Oct 9, 2025
saikrishna321 approved these changes Oct 9, 2025
SrinivasanTarget approved these changes Oct 9, 2025
ValeriiMelnyk approved these changes Mar 20, 2026
Copy link Copy Markdown
ValeriiMelnyk
left a comment
ValeriiMelnyk
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants