Home Original page

DoubleTap Support by rafe-g · Pull Request #444 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@rafe-g

Change list

DoubleTap support to TouchAction

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@rafe-g

@SrinivasanTarget

Awesome. Can you add some tests please? Will review soon.

@TikhomirovSergey

tests
+1

@Rafael-Chavez
Also
could you provide tests for both Android and iOS?

rafe-g

firstField.sendKeys("2");
driver.doubleTap(firstField);
IOSElement editingMenu = (IOSElement) driver.findElementByClassName("UIAEditingMenu");
assertNotNull(editingMenu);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was little to double tap on in ios TestApp. But found the editing menu shows up when you double tap on one of the fields.

@rafe-g

rafe-g

@Test public void doubleTapTest() throws Exception {
driver.startActivity("io.appium.android.apis", ".view.TextSwitcher1");
String textBeforeDoubleTap = (driver.findElementByClassName("android.widget.TextView")).getText();
AndroidElement next = driver.findElementById("io.appium.android.apis:id/next");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next is used

@SrinivasanTarget

@rafe-g

i will update with the javadoc and style fixes.

@rafe-g

@SrinivasanTarget

@rafe-g

that error makes sense @SrinivasanTarget as i only added doubleTap support for iOS driver in appium. I dont see support for double tap (or double click) in uiautomator.

@SrinivasanTarget

@Rafael-Chavez Yes i see that there is no support for doubleTap in appium-android-driver. I would suggest to move this to IOSDriver.java instead of AppiumDriver.java as there is no support. What do you say @TikhomirovSergey ? Or we should throw appropriate NotYetImplemented error.

@rafe-g

@rafe-g

@rafe-g

@rafe-g

@SrinivasanTarget

@Rafael-Chavez Apologies for the delay. I'm on vacation till 12th Sep. We were working on splitting TouchActions as you can see here, #458. We will get this in soon. @TikhomirovSergey FYI

Labels