#567 fix by TikhomirovSergey · Pull Request #568 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

TikhomirovSergey merged 1 commit intoappium:masterfrom

TikhomirovSergey:master

Feb 13, 2017

Merged

#567 fix#568

TikhomirovSergey merged 1 commit intoappium:masterfrom

TikhomirovSergey:master

Conversation

@TikhomirovSergey

Copy link Copy Markdown

Contributor

@TikhomirovSergey TikhomirovSergey commented

Feb 10, 2017

edited

Loading

Change list

#567 fix

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

  • 'isBrowserMethod' is not implemented by default;
  • element generaration was reverted to the old rule which was used before 5.0.0-BETA1

@TikhomirovSergey

Copy link Copy Markdown

Contributor Author

@amedvedjev @derunewige
You are invided to review/try this PR too.
If everything is ok then it will be published immideately at the BETA3.

PS. Appium field decorator was changed a little bit. It is not the breaking change... bit it is starting of the refactoring. It is related to the feature request opened by @amedvedjev. It is supposed to be finished at the BETA4.

@amedvedjev

Copy link Copy Markdown

@TikhomirovSergey can you give advice how i can try this pull with mine maven project easily?

@TikhomirovSergey TikhomirovSergey merged commit 3d18252 into appium:master

Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Labels

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TikhomirovSergey @amedvedjev @SrinivasanTarget