#567 fix by TikhomirovSergey · Pull Request #568 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
Conversation
Copy link Copy Markdown
Contributor
Change list
#567 fix
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
- 'isBrowserMethod' is not implemented by default;
- element generaration was reverted to the old rule which was used before 5.0.0-BETA1
TikhomirovSergey
added
the
bug
label
TikhomirovSergey
self-assigned this
TikhomirovSergey
requested a review
from SrinivasanTarget
TikhomirovSergey
added this to the
5.0.0 milestone
Copy link Copy Markdown
Contributor Author
TikhomirovSergey
commented
Feb 10, 2017
TikhomirovSergey commented
Feb 10, 2017@amedvedjev @derunewige
You are invided to review/try this PR too.
If everything is ok then it will be published immideately at the BETA3.
PS. Appium field decorator was changed a little bit. It is not the breaking change... bit it is starting of the refactoring. It is related to the feature request opened by @amedvedjev. It is supposed to be finished at the BETA4.
Copy link Copy Markdown
amedvedjev
commented
Feb 10, 2017
amedvedjev commented
Feb 10, 2017@TikhomirovSergey can you give advice how i can try this pull with mine maven project easily?
SrinivasanTarget approved these changes Feb 13, 2017
TikhomirovSergey
merged commit
3d18252
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment