Fix #704 by SrinivasanTarget · Pull Request #705 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

TikhomirovSergey merged 1 commit intoappium:masterfrom

SrinivasanTarget:masterfix

Aug 28, 2017

Merged

Fix #704#705

TikhomirovSergey merged 1 commit intoappium:masterfrom

SrinivasanTarget:masterfix

Conversation

@SrinivasanTarget

Copy link Copy Markdown

Member

Change list

Fix #704 that breaks iOS test execution.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@TikhomirovSergey ping

Copy link Copy Markdown

Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy fix

@TikhomirovSergey

Copy link Copy Markdown

Contributor

TikhomirovSergey commented

Aug 28, 2017

edited

Loading

@SrinivasanTarget @mykola-mokhnach Will merge and publish it today evening (28.08.2017)

SrinivasanTarget reacted with thumbs up emoji

@TikhomirovSergey TikhomirovSergey merged commit 6deca60 into appium:master

Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

+1 more reviewer

@TikhomirovSergey TikhomirovSergey TikhomirovSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5.0.0: Brokes iOS tests

3 participants

@SrinivasanTarget @TikhomirovSergey @mykola-mokhnach