#718 FIX by TikhomirovSergey · Pull Request #722 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
Conversation
Copy link Copy Markdown
Contributor
Change list
#718 FIX
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
There was the dependency conflict inside java_clint. As it was resolved by exclusion of malformed artefacts, I think we could return selenium dependency version to its normal form with force compilation. I think that it is the case when the simple solution is enough.
TikhomirovSergey added 2 commits
September 4, 2017 21:27
TikhomirovSergey
requested review from
SrinivasanTarget and
mykola-mokhnach
| } | ||
|
|
||
| ext.seleniumVersion = '[3.5.3,3.5.3]' | ||
| ext.seleniumVersion = '3.5.3' |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a comment here about version number format restriction
mykola-mokhnach approved these changes Sep 7, 2017
SrinivasanTarget approved these changes Sep 8, 2017
TikhomirovSergey
merged commit
c9b80c8
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants