Update to Selenium 3.8.1 by TikhomirovSergey · Pull Request #797 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
TikhomirovSergey merged 1 commit intoappium:masterfrom
TikhomirovSergey:master
TikhomirovSergey merged 1 commit intoappium:masterfrom
TikhomirovSergey:master
Conversation
Copy link Copy Markdown
Contributor
TikhomirovSergey
commented
Dec 23, 2017
TikhomirovSergey
commented
Change list
- Update to Selenium 3.8.1
- Removal of deprecated listener-methods from the AlertEventListener. These methods were
being invoked before/after authentication.
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Removal of deprecated listener-methods from the AlertEventListener. These methods were being invoked before/after authentication.
TikhomirovSergey
requested review from
SrinivasanTarget and
mykola-mokhnach
mykola-mokhnach approved these changes Dec 23, 2017
SrinivasanTarget approved these changes Dec 24, 2017
Copy link Copy Markdown
Member
SrinivasanTarget
left a comment
SrinivasanTarget
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TikhomirovSergey
merged commit
953b106
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants