Add handlers for lock/unlock in iOS by mykola-mokhnach · Pull Request #799

Add handlers for lock/unlock in iOS by mykola-mokhnach · Pull Request #799 · appium/java-client

Change list

Please do not merge it unless appium/appium-xcuitest-driver#595 is published

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

		@@ -27,11 +29,30 @@ public interface LocksIOSDevice extends ExecutesMethod {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deprecate both LocksIOSDevice and LocksAndroidDevice. Have LocksDevice interface instead. Currently based on this PR both android and iOS both does supports the API except this method in android doesn't accept duration. May be a server fix will make the API work like iOS.

Done

https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java#L182 can be removed since MobileCommand will have it.

Done

isDeviceLocked as like in this PR makes more sense to me instead of isLocked as in android now. So we might need to deprecate that and rename in android to make it consistent.

Done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is necessary to replace isLocked with isDeviceLocked method.

Also I think that new methods should be covered with iOS tests.

As soon as we are waiting for merge of appium/appium-xcuitest-driver#595 so let this message be somethng like reminder

Mykola Mokhnach added 3 commits

January 30, 2018 22:42

… into lock

# Conflicts:
#	src/main/java/io/appium/java_client/android/AndroidMobileCommandHelper.java
#	src/main/java/io/appium/java_client/android/LocksAndroidDevice.java

@TikhomirovSergey I've added integration tests for iOS. The isLocked method has been marked as deprecated.