Add a possibility to set pressure value for iOS by mykola-mokhnach · Pull Request #879 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
SrinivasanTarget merged 2 commits intoappium:masterfrom
Apr 29, 2018Merged
Add a possibility to set pressure value for iOS#879
SrinivasanTarget merged 2 commits intoappium:masterfrom
Add a possibility to set pressure value for iOS#879
SrinivasanTarget merged 2 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Apr 27, 2018
mykola-mokhnach
commented
Change list
Based on appium/WebDriverAgent#79
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
This will allow to automate 3D Touch/Force touch scenarios for iOS
mykola-mokhnach
requested a review
from SrinivasanTarget
Copy link Copy Markdown
Member
SrinivasanTarget
commented
Apr 27, 2018
SrinivasanTarget commented
Apr 27, 2018@mykola-mokhnach Code Looks good. Can you add a test please?
Copy link Copy Markdown
Contributor Author
mykola-mokhnach
commented
Apr 27, 2018
mykola-mokhnach commented
Apr 27, 2018Yep I can, however it won't work until the corresponding PR is merged and published
Copy link Copy Markdown
Member
SrinivasanTarget
commented
Apr 27, 2018
SrinivasanTarget commented
Apr 27, 2018@mykola-mokhnach Is it possible to perform 3D touch using this?
Copy link Copy Markdown
Contributor Author
mykola-mokhnach
commented
Apr 27, 2018
mykola-mokhnach commented
Apr 27, 2018it should be
Copy link Copy Markdown
Member
SrinivasanTarget
commented
Apr 27, 2018
SrinivasanTarget commented
Apr 27, 2018Ok will try it
Copy link Copy Markdown
Contributor
TikhomirovSergey
commented
Apr 27, 2018
TikhomirovSergey commented
Apr 27, 2018@SrinivasanTarget Waiting for your approval. Would be cool to include it to 6.0.0
SrinivasanTarget approved these changes Apr 29, 2018
SrinivasanTarget
merged commit
5e5e993
into
appium:master
mykola-mokhnach
deleted the
pressure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants