Adding the new server arguments by shridharkalagi · Pull Request #880 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
SrinivasanTarget merged 2 commits intoappium:masterfrom
Apr 27, 2018Merged
Adding the new server arguments#880
SrinivasanTarget merged 2 commits intoappium:masterfrom
Adding the new server arguments#880
SrinivasanTarget merged 2 commits intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
shridharkalagi
commented
Apr 27, 2018
shridharkalagi
commented
Change list
Adding the new server arguments for --relaxed-security and --enable-heapdump
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Copy link Copy Markdown
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
| */ | ||
| ASYNC_TRACE("--async-trace"); | ||
| ASYNC_TRACE("--async-trace"), | ||
|
|
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any practical sense in these double line breaks between items
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach Updated.
mykola-mokhnach approved these changes Apr 27, 2018
SrinivasanTarget approved these changes Apr 27, 2018
SrinivasanTarget
merged commit
d8f9aad
into
appium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment