Add an optional format argument to getDeviceTime and update the documentation by mykola-mokhnach · Pull Request #939 · appium/java-client

Conversation

@mykola-mokhnach

Change list

Now it is possible to explicitly set the format specifiers for the returned datetime. Also, the default response format is changed to ISO-8601

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Mykola Mokhnach added 2 commits

June 12, 2018 10:58

SrinivasanTarget


@Test public void getDeviceTimeTest() {
String time = driver.getDeviceTime();
assertTrue(time.length() == 28);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import statement can also be removed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which import?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still used by isAppInstalledTest and lockTest. Codacy usually highlights such cases automatically.

SrinivasanTarget

2 participants

@mykola-mokhnach @SrinivasanTarget