Switch web socket client implementation to okhttp library by mykola-mokhnach · Pull Request #941 · appium/java-client
Navigation Menu
{{ message }}
appium / java-client Public
- Notifications You must be signed in to change notification settings
- Fork 763
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom
Jun 13, 2018Merged
Switch web socket client implementation to okhttp library#941
mykola-mokhnach merged 1 commit intoappium:masterfrom
Switch web socket client implementation to okhttp library#941
mykola-mokhnach merged 1 commit intoappium:masterfrom
Conversation
Copy link Copy Markdown
Contributor
mykola-mokhnach
commented
Jun 13, 2018
mykola-mokhnach
commented
Change list
Selenium anyway uses okhttp, so it is a good idea to reuse it to interact with web sockets. Also this allows to get rid of some not really necessary dependencies.
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
mykola-mokhnach
requested review from
SrinivasanTarget and
TikhomirovSergey
SrinivasanTarget approved these changes Jun 13, 2018
mykola-mokhnach
merged commit
05fa225
into
appium:master
mykola-mokhnach
deleted the
ok_http_ws
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment