Home Original page

Add support for "-image" locator type by mykola-mokhnach · Pull Request #990 · appium/java-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mykola-mokhnach

Copy link Copy Markdown

Contributor

Change list

Based on appium/appium-base-driver#235

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
saikrishna321 reacted with hooray emoji

@mykola-mokhnach

Copy link Copy Markdown

Contributor Author

@jlipps FYI

Copy link Copy Markdown

Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it worked well. Once appium/appium-uiautomator2-server#181 is published one can start interacting at element level by images. Thanks for it @mykola-mokhnach .

Copy link Copy Markdown

Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I also think it'd be nice to have helper methods which easily allow finding by image path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlipps jlipps jlipps left review comments

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mykola-mokhnach @jlipps @SrinivasanTarget