Expand touch options API to accept coordinates as Point by valfirst · Pull Request #997 · appium/java-client
Change list
Expand touch options API to accept coordinates as org.openqa.selenium.Point
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
| public void tapOptionsShouldBuildProperly() { | ||
| final Map<String, Object> actualOpts = tapOptions() | ||
| .withPosition(point(0, 0)) | ||
| .withPosition(point(new Point(0, 0))) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so now both would be possible: point(0, 0) and point(new Point(0, 0)) ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes both are possible now.
valfirst
deleted the
use-coordinates-as-point
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters