fix: typo by umitdemirci · Pull Request #153 · apple/container
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 683
Merged
katiewasnothere merged 3 commits intoapple:mainfrom
Jun 13, 2025Merged
fix: typo#153
katiewasnothere merged 3 commits intoapple:mainfrom
fix: typo#153
katiewasnothere merged 3 commits intoapple:mainfrom
Conversation
katiewasnothere approved these changes Jun 12, 2025
Copy link
Contributor
katiewasnothere
left a comment
katiewasnothere
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Will merge once the CI runs :)
Copy link
Contributor
katiewasnothere
commented
Jun 12, 2025
katiewasnothere commented
Jun 12, 2025Looks like your commits aren't signed. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification for setting up commit signatures.
umitdemirci
force-pushed
the
main
branch
3 times, most recently
from
781a41b to
dcf28d6
Compare
umitdemirci
force-pushed
the
main
branch
from
dcf28d6 to
c3a34e8
Compare
Copy link
Contributor Author
umitdemirci
commented
Jun 12, 2025
umitdemirci commented
Jun 12, 2025Looks like your commits aren't signed. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification for setting up commit signatures.
Signed it.
Copy link
Contributor
katiewasnothere
commented
Jun 12, 2025
katiewasnothere commented
Jun 12, 2025@umitdemirci Can you rebase your PR on main? Sorry about that, we fixed the proto generation here
Copy link
Contributor Author
umitdemirci
commented
Jun 12, 2025
umitdemirci commented
Jun 12, 2025@umitdemirci Can you rebase your PR on main? Sorry about that, we fixed the proto generation here
I think it's done :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment