define JSONDecoder() outside of for loop in load() by elijah-wright · Pull Request #159 · apple/container

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@elijah-wright

Copy link

Contributor

@elijah-wright elijah-wright commented

Jun 12, 2025

edited

Loading

this PR defines a variable, decoder, which represents the JSONDecoder class, rather than doing it in the for loop in load()

@dcantah

Copy link

Member

dcantah commented

Jun 12, 2025

Thanks

@katiewasnothere

Copy link

Contributor

Hi @elijah-wright could you rebase your PR? Sorry about that, I made a fix for the CI issue here #176

Signed-off-by: Elijah Wright <git@elijahs.space>

@elijah-wright

Copy link

Contributor Author

ok, I just rebased it

katiewasnothere reacted with rocket emoji

@katiewasnothere katiewasnothere merged commit 7ca5a43 into apple:main

Jun 12, 2025

2 checks passed

@elijah-wright elijah-wright deleted the jsondecoder branch

June 12, 2025 18:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elijah-wright @dcantah @katiewasnothere