define JSONDecoder() outside of for loop in load() by elijah-wright · Pull Request #159 · apple/container
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 678
Merged
katiewasnothere merged 1 commit intoapple:mainfrom
Jun 12, 2025Merged
define JSONDecoder() outside of for loop in load()#159
katiewasnothere merged 1 commit intoapple:mainfrom
define JSONDecoder() outside of for loop in load()#159
katiewasnothere merged 1 commit intoapple:mainfrom
Conversation
Copy link
Contributor
this PR defines a variable, decoder, which represents the JSONDecoder class, rather than doing it in the for loop in load()
elijah-wright
force-pushed
the
jsondecoder
branch
from
2d1dccf to
a10fc13
Compare
dcantah approved these changes Jun 12, 2025
Copy link
Member
dcantah
commented
Jun 12, 2025
dcantah commented
Jun 12, 2025Thanks
Copy link
Contributor
katiewasnothere
commented
Jun 12, 2025
katiewasnothere commented
Jun 12, 2025Hi @elijah-wright could you rebase your PR? Sorry about that, I made a fix for the CI issue here #176
elijah-wright
force-pushed
the
jsondecoder
branch
from
a10fc13 to
14358f3
Compare
Signed-off-by: Elijah Wright <git@elijahs.space>
elijah-wright
force-pushed
the
jsondecoder
branch
from
14358f3 to
c30f7a9
Compare
Copy link
Contributor Author
elijah-wright
commented
Jun 12, 2025
elijah-wright commented
Jun 12, 2025ok, I just rebased it
elijah-wright
deleted the
jsondecoder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment