Fix user arg passthrough for container create by katiewasnothere · Pull Request #393 · apple/container
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 677
Merged
katiewasnothere merged 1 commit intoapple:mainfrom
Jul 29, 2025Merged
Fix user arg passthrough for container create#393
katiewasnothere merged 1 commit intoapple:mainfrom
Fix user arg passthrough for container create#393
katiewasnothere merged 1 commit intoapple:mainfrom
Conversation
Copy link
Contributor
This matches other container commands that rely on user arguments at the end, such as container run. Closes #395.
dcantah approved these changes Jul 29, 2025
Copy link
Member
dcantah
commented
Jul 29, 2025
dcantah commented
Jul 29, 2025I approved a little hastily, can we make a simple test to create some container where the args uses something we would interpret as a flag and verify we don't fail (or whatever you think would be a good test).
dcantah
self-requested a review
katiewasnothere
force-pushed
the
container_create_arg_passthru
branch
from
1d01712 to
a18f490
Compare
Copy link
Contributor Author
katiewasnothere
commented
Jul 29, 2025
katiewasnothere commented
Jul 29, 2025@dcantah added a simple test!
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
container_create_arg_passthru
branch
from
a18f490 to
35040c3
Compare
dcantah approved these changes Jul 29, 2025
katiewasnothere
deleted the
container_create_arg_passthru
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants