Add a build parameter to handle warnings as errors by dkovba · Pull Request #591 · apple/container

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@dkovba

Copy link

Contributor

@dkovba dkovba commented

Sep 9, 2025

To handle warnings as errors when building, use make. To allow warnings, use make WARNINGS_AS_ERRORS=false test.

Also see apple/containerization#271.

Copy link

Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the merge conflicts are fixed

dkovba reacted with thumbs up emoji

@dkovba dkovba force-pushed the dkovba/warnings-as-errors branch from 9932d66 to 015b375 Compare

September 9, 2025 22:24

@dkovba dkovba merged commit f3db805 into apple:main

Sep 10, 2025

2 checks passed

@dkovba dkovba deleted the dkovba/warnings-as-errors branch

September 10, 2025 00:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglogan jglogan jglogan approved these changes

@katiewasnothere katiewasnothere Awaiting requested review from katiewasnothere

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkovba @jglogan @katiewasnothere